Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serviceinfo-sys-module.md #17

Merged
merged 5 commits into from
Aug 19, 2021
Merged

Update serviceinfo-sys-module.md #17

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e9e13a
Update serviceinfo-sys-module.md
sharoncornelius Aug 16, 2021
996e39f
Adding signature
DukeDavis12 Aug 16, 2021
00fe3e1
Merge branch 'master' into sharoncornelius-patch-5
DukeDavis12 Aug 19, 2021
3230e3c
Merge branch 'master' into sharoncornelius-patch-5
DukeDavis12 Aug 19, 2021
88e968f
final updates
DukeDavis12 Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/implementation-references/serviceinfo-sys-module.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ follow.
## Examples
Below are examples of the fdo_sys messages encoded as CBOR. The JSON examples are just human
readable definitions while the actual messages are always CBOR. The encoding includes the entire
TO2.OwnerServiceInfo message include the isMore and isDone flags.
TO2. OwnerServiceInfo message include the isMore and isDone flags.
DukeDavis12 marked this conversation as resolved.
Show resolved Hide resolved

Device should advertise it supports fdo_sys.

Expand Down Expand Up @@ -90,7 +90,7 @@ Device should advertise it supports fdo_sys.
| Diagnostic Notation (not used by protocol) | [false, true, [[["fdo_sys:exec", ["cmd", "/c", "startup.bat"]]]] |
| CBOR | `83` # array(3) <br> `F4` # primitive(20) - IsMoreSeviceInfo <br> `F5` # primitive(21) - IsDone <br> `81` # array(1) - ServiceInfo <br> `81` # array(1) - ServiceInfo Key-Value Array <br> `82` # array(2) - ServiceInfo Key-Value Pair <br> `6C` # text(12) <br> `66646F5F7379733A65786563` # "fdo_sys:exec" <br> `83` # array(3) <br> `63` # text(3) <br> `636D64` # "cmd" <br> `62` # text(2) <br> `2F63` # "/c" <br> `6B` # text(11) <br> `737461727475702E626174` # "startup.bat" |

#### ismore flag
#### ismore Flag

The 'ismore' more should be true is if the message being sent is not a complete processable message. All fdo_sys messages are complete messages, so the 'ismore' flag will always be true in this case.

Expand Down