Makefile: allow buliding with podman too #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runcom
force-pushed
the
customize-container-runtime
branch
from
ba403e2 to
8da697b
Compare
Signed-off-by: Antonio Murdaca <amurdaca@redhat.com>
runcom
force-pushed
the
customize-container-runtime
branch
from
8da697b to
0207e1f
Compare
When using distroless tag `nonroot` we don't need to use the USER directive in the Dockerfile. Plus, nonroot can't write to /app or anywhere else so we should prefix the db path with nonroot's home as well in order to avoid a sketchy permission denied. Signed-off-by: Antonio Murdaca <amurdaca@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have
podmanavailable on my Fedora system and I'd love to use it to build the project. This patch just makes it possible to default todockerbut allows for different container runtimes too (e.g.make build CONTAINER_RUNTIME=podman)