Skip to content

Commit

Permalink
fix(tournamentv5): tournament game details return type fix (#546)
Browse files Browse the repository at this point in the history
* fix(tournamentv5): tournament game details return type fix

* fix(matchv5): add endOfGameResult missing property
  • Loading branch information
OllieJennings authored Mar 2, 2024
1 parent 03d0eb3 commit 2d7ad52
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions __tests__/e2e/match_v5.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ describe("E2E", () => {

expect(resp).toContainAllKeys(["metadata", "info"]);
expect(resp.info).toContainAllKeys([
"endOfGameResult",
"gameCreation",
"gameDuration",
"gameId",
Expand Down
1 change: 1 addition & 0 deletions src/@types/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1108,6 +1108,7 @@ export namespace RiotAPITypes {
}

export interface MatchInfoDTO {
endOfGameResult: string;
gameCreation: number;
gameDuration: number;
gameId: number;
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1517,7 +1517,7 @@ export class RiotAPI {
tournamentCode,
}: {
tournamentCode: string;
}): Promise<RiotAPITypes.TournamentV5.TournanmentGamesV5DTO> =>
}): Promise<RiotAPITypes.TournamentV5.TournanmentGamesV5DTO[]> =>
this.request(
PlatformId.AMERICAS,
RiotAPITypes.METHOD_KEY.TOURNAMENT_V5.GET_TOURNAMENT_GAME_DETAILS,
Expand Down

0 comments on commit 2d7ad52

Please sign in to comment.