GoReleaser: Clone code out of gpg action #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hashicorp dev recommends switching to |
|
nice find! |
|
oh oops i didn't mean to just outright close the PR, i was trying to fidget to get the action to run |
|
running at https://github.com/figma/terraform-provider-aws/actions/runs/2678205492 if it works then i'll just run with it, if not then i'll make another branch and PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goreleaser is bumping into this error:
I took an old commit sha and pushed it again, and it hit the same issue. The other day I wasn't having this issue, I was trying to fix an issue further in the pipeline but it seemed to regress. I suspect that the github actions environment very recently changed, breaking this.
This PR takes most logic out of the action we were depending on and just runs that directly so that we can avoid the step with the gpg agent.
Test
made it at least beyond that part