Fix #16236

fiigii · Feb 13, 2018 · a4f5523 · a4f5523
1 parent 53d7ceb
commit a4f5523
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 5 deletions.
diff --git a/src/jit/compiler.h b/src/jit/compiler.h
@@ -7634,6 +7634,25 @@ XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
         return pTypeInfo->IsStruct() && isSIMDClass(pTypeInfo->GetClassHandleForValueClass());
     }
 
+    bool isHWSIMDClass(CORINFO_CLASS_HANDLE clsHnd)
+    {
+        if (isIntrinsicType(clsHnd))
+        {
+            const char* namespaceName = nullptr;
+            (void)getClassNameFromMetadata(clsHnd, &namespaceName);
+            return strcmp(namespaceName, "System.Runtime.Intrinsics") == 0;
+        }
+        else
+        {
+            return false;
+        }
+    }
+
+    bool isHWSIMDClass(typeInfo* pTypeInfo)
+    {
+        return pTypeInfo->IsStruct() && isHWSIMDClass(pTypeInfo->GetClassHandleForValueClass());
+    }
+
     // Get the base (element) type and size in bytes for a SIMD type. Returns TYP_UNKNOWN
     // if it is not a SIMD type or is an unsupported base type.
     var_types getBaseTypeAndSizeOfSIMDType(CORINFO_CLASS_HANDLE typeHnd, unsigned* sizeBytes = nullptr);

diff --git a/src/jit/importer.cpp b/src/jit/importer.cpp
@@ -18277,7 +18277,11 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo)
         // the inlining multiplier) for anything in that assembly.
         // But we only need to normalize it if it is a TYP_STRUCT
         // (which we need to do even if we have already set foundSIMDType).
-        if ((!foundSIMDType || (sigType == TYP_STRUCT)) && isSIMDClass(&(lclVarInfo[0].lclVerTypeInfo)))
+        if ((!foundSIMDType || (sigType == TYP_STRUCT)) && (isSIMDClass(&(lclVarInfo[0].lclVerTypeInfo))
+#ifdef FEATURE_HW_INTRINSICS
+                                                            || isHWSIMDClass(&(lclVarInfo[0].lclVerTypeInfo))
+#endif
+                                                                ))
         {
             if (sigType == TYP_STRUCT)
             {
@@ -18344,7 +18348,11 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo)
         lclVarInfo[i].lclVerTypeInfo = verParseArgSigToTypeInfo(&methInfo->args, argLst);
 
 #ifdef FEATURE_SIMD
-        if ((!foundSIMDType || (sigType == TYP_STRUCT)) && isSIMDClass(&(lclVarInfo[i].lclVerTypeInfo)))
+        if ((!foundSIMDType || (sigType == TYP_STRUCT)) && (isSIMDClass(&(lclVarInfo[i].lclVerTypeInfo))
+#ifdef FEATURE_HW_INTRINSICS
+                                                            || isHWSIMDClass(&(lclVarInfo[i].lclVerTypeInfo))
+#endif
+                                                                ))
         {
             // If this is a SIMD class (i.e. in the SIMD assembly), then we will consider that we've
             // found a SIMD type, even if this may not be a type we recognize (the assumption is that
@@ -18520,7 +18528,11 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo)
         localsSig = info.compCompHnd->getArgNext(localsSig);
 
 #ifdef FEATURE_SIMD
-        if ((!foundSIMDType || (type == TYP_STRUCT)) && isSIMDClass(&(lclVarInfo[i + argCnt].lclVerTypeInfo)))
+        if ((!foundSIMDType || (type == TYP_STRUCT)) && (isSIMDClass(&(lclVarInfo[i + argCnt].lclVerTypeInfo))
+#ifdef FEATURE_HW_INTRINSICS
+                                                         || isHWSIMDClass(&(lclVarInfo[i + argCnt].lclVerTypeInfo))
+#endif
+                                                             ))
         {
             foundSIMDType = true;
             if (featureSIMD && type == TYP_STRUCT)
@@ -18533,7 +18545,11 @@ void Compiler::impInlineInitVars(InlineInfo* pInlineInfo)
     }
 
 #ifdef FEATURE_SIMD
-    if (!foundSIMDType && (call->AsCall()->gtRetClsHnd != nullptr) && isSIMDClass(call->AsCall()->gtRetClsHnd))
+    if (!foundSIMDType && (call->AsCall()->gtRetClsHnd != nullptr) && (isSIMDClass(call->AsCall()->gtRetClsHnd)
+#ifdef FEATURE_HW_INTRINSICS
+                                                                       || isHWSIMDClass(call->AsCall()->gtRetClsHnd)
+#endif
+                                                                           ))
     {
         foundSIMDType = true;
     }

diff --git a/src/jit/lclvars.cpp b/src/jit/lclvars.cpp
@@ -1564,7 +1564,11 @@ void Compiler::lvaCanPromoteStructType(CORINFO_CLASS_HANDLE    typeHnd,
             // Check to see if this is a SIMD type.
             // We will only check this if we have already found a SIMD type, which will be true if
             // we have encountered any SIMD intrinsics.
-            if (usesSIMDTypes() && (pFieldInfo->fldSize == 0) && isSIMDClass(pFieldInfo->fldTypeHnd))
+            if (usesSIMDTypes() && (pFieldInfo->fldSize == 0) && (isSIMDClass(pFieldInfo->fldTypeHnd)
+#ifdef FEATURE_HW_INTRINSICS
+                                                                  || isHWSIMDClass(pFieldInfo->fldTypeHnd)
+#endif
+                                                                      ))
             {
                 unsigned  simdSize;
                 var_types simdBaseType = getBaseTypeAndSizeOfSIMDType(pFieldInfo->fldTypeHnd, &simdSize);

diff --git a/src/jit/morph.cpp b/src/jit/morph.cpp
@@ -19030,6 +19030,13 @@ Compiler::fgWalkResult Compiler::fgMarkAddrTakenLocalsPreCB(GenTree** pTree, fgW
             }
             else
 #endif // FEATURE_SIMD
+#ifdef FEATURE_HW_INTRINSICS
+                if (tree->gtOp.gtOp1->OperGet() == GT_HWIntrinsic)
+            {
+                axcStack->Push(AXC_None);
+            }
+            else
+#endif // FEATURE_HW_INTRINSICS
                 if (axc == AXC_Ind)
             {
                 axcStack->Push(AXC_None);