Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More errors #1

Merged
merged 5 commits into from
Mar 25, 2019
Merged

More errors #1

merged 5 commits into from
Mar 25, 2019

Conversation

fijimunkii
Copy link
Owner

  • add error handlers to all streams
  • handle common socket errors
  • include source stream in error handler

Streams changed recently ( nodejs/node#18438 ) in node 10 to not end gracefully on error events. To avoid fatal errors, error handlers are added to all relevant streams. Common socket errors are handled to avoid unnecessary errors

@fijimunkii fijimunkii merged commit 43da066 into master Mar 25, 2019
@fijimunkii fijimunkii deleted the more-errors branch March 25, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant