Fix $persist breaking Alpine when Tabs are used in modals #12191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can persist the currently active
Tab
to localStorage:I can see the value being updated and written in devtools when the tab is changed. However, when tabs are used in a modal which is being dismissed, the value of
tab
is incorrectly set toundefined
during a Livewire commit hook.When opening the modal again, the UI breaks and nothing is rendered. This error appears in the console:
The fix seems to be to fall back to the current tab, instead of trying to persist a potentially undefined array offset.
Visual changes
N/A
Functional changes
composer cs
command.