accept float
(decimal values) directly in multipleOf()
rule helper
#13705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Laravel, the
multipleOf()
validation rule accepts integers or decimals. Proper handling decimal values was addressed specifically in a Laravel framework PR after being brought up as a separate issue.In Filament, the current signature of
multipleOf()
accepts eitherint
orClosure
:Strictly speaking, this doesn't preclude us from using decimal values here, but doing so requires a
Closure
:Another workaround would be using
rules()
:Either of these work just fine by proxying down to the Laravel rule, which validates as expected. Therefore, I am proposing that we also accept
float
into themultipleOf()
helper method. Doing so would preclude the need to work around the issue as above, and also adhere to the way that a developer would be expect to be able to use this helper.Visual changes
No visual changes included in this PR.
Functional changes
composer cs
command.No tests currently cover this method, therefore none need modifying.
No documentation currently covers this method in that level of detail, nor do I feel it strictly necessary to call this out in the documentation.