Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Badge columns unexpectedly ignoring falsy values #846

Merged
merged 2 commits into from
Dec 14, 2021
Merged

fix: Badge columns unexpectedly ignoring falsy values #846

merged 2 commits into from
Dec 14, 2021

Conversation

capibawa
Copy link
Contributor

Badge columns will currently ignore any falsy values such as 0 or '0'.

My proposed solution is to explicitly check that the formatted state is null.

@danharrin
Copy link
Member

Thanks! Switched to blank() which also fails empty strings as well as null :)

@danharrin danharrin merged commit b870154 into filamentphp:2.x Dec 14, 2021
@danharrin danharrin added the bug Something isn't working label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capibawa @danharrin