Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation to provide scripts to daemonize, solves #4 #41

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mckaygerhard
Copy link

@mckaygerhard mckaygerhard commented Oct 22, 2021

This merge request will provide examles to the issue #4 also improved ways to use in background on any server with limited privilegies

references to solve: filebrowser/filebrowser#453 (comment) and filebrowser/filebrowser#418

@jniggemann
Copy link

This is IMHO a very valuable contribution, thank you! Hope this gets merged soon, as quite a lot of people ask about init scripts. Can you please add a systemd service file?

@mckaygerhard
Copy link
Author

i do not use SHITstemd.. sorry in any case winbuntu system easyle converts the sysvinit to the current init system running as i know so you dont need to have problems..

@o1egl i am waiting for this to be merged to continue fixin documentation cos some other changes will need interaction and will touch several files.. thanks in advance

@jniggemann
Copy link

i do not use SHITstemd..

And neither do I, but why make this emotional? Let's keep this technical.

sorry in any case winbuntu system easyle converts the sysvinit to the current init system running as i know so you dont need to have problems..

Why should I have problems? I've been using Linux since 1998 and have no problems using it :-)
Think about it: Even if you (and I) dislike systemd, the vast majority of this projects' userbase probably uses it. And the documentation should educate / benefit the users, so I proposed including an example.
“Always pass on what you have learned.” - Yoda

That said, here's a shot at a service file. Untested, obviously.

[Unit]
Description=Filebrowser
After=network-online.target

[Service]
User=<user>
Group=<group>

ExecStart=/usr/local/bin/filebrowser

[Install]
WantedBy=multi-user.target

@mckaygerhard
Copy link
Author

i do not use SHITstemd..
And neither do I, but why make this emotional? Let's keep this technical.
sorry in any case winbuntu system easyle converts the sysvinit to the current init system running as i know so you dont need to have problems..
Why should I have problems? I've been using Linux since 1998 and have no problems using it :-)

i mean that any that want that thing just use the sysvinit script and those system will automatically provide a just-in-time unit when used! as i read in debian "fights" maillist of devuan initiative XD

also for that: you can made a merge request after this are merged! i do not work with those things

That said, here's a shot at a service file. Untested, obviously.

[Unit]
Description=Filebrowser
After=network-online.target

[Service]
User=<user>
Group=<group>

ExecStart=/usr/local/bin/filebrowser

[Install]
WantedBy=multi-user.target

@mckaygerhard
Copy link
Author

@o1egl some time passed and tehre's PR pending here! i guess you should delegate some functions.. by exampled @ramiresviana is pretty notable here.. so he can organize and aswered the issu3es and close it when is unrelated..

please.. if you cannot take delegate task for.. ! @o1egl

@mckaygerhard
Copy link
Author

plase also could you take a watch over this @o1egl also?

annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/quick-how-to-start-filebrowser.md Show resolved Hide resolved
@mckaygerhard
Copy link
Author

Hi @o1egl i reduced and try to fix.. but please considering that it seems you are viewing all the documentation as a developer only, we need to step on the shoes of the atrgeted people that will use the program.. not as a developer that already "have basic knowledge" that are not so basic for others..

@o1egl
Copy link
Member

o1egl commented Jan 16, 2022

Hi @o1egl i reduced and try to fix.. but please considering that it seems you are viewing all the documentation as a developer only, we need to step on the shoes of the atrgeted people that will use the program.. not as a developer that already "have basic knowledge" that are not so basic for others..

If one is able to run a cli application, I'm sure they're familiar with shell basics like nohup, etc.

annexes/init-scripts-and-daemonize.md Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
annexes/init-scripts-and-daemonize.md Outdated Show resolved Hide resolved
mckaygerhard and others added 5 commits January 17, 2022 10:47
Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
…or data database.. (still pending other path)

Co-authored-by: Oleg Lobanov <oleg@lobanov.me>
* database file must not be a of the server root folder. Let's change it to /var/lib/filebrowser/filebrowser.db
* removes the "resetconfig" part that is not need as suggested
* Let's change it to something common, like 8080, but used 8090 if we are a noob user with apache LAMP setup
* but the port also in the init basic scripts so more noobs users feels more familiars .. as forums pointed
* removed too many variables as suggested "This should not be set by default"
* removed default username admin changed as suggested "Why is the default username changed"
* name is used by script as i learn.. but then used also in the pid name to be happy
* reduced the openrc as suggested but start still is need cos we need to specify the "exec as" with tyhe PID file to get working states
@mckaygerhard
Copy link
Author

Hi @o1egl resolved all exep that start must be there' for openrc.. i tested in my alpine 3.8 and i need this cos if i removed. start prefectly but rest of states never worked..

Copy link

@ciband ciband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too am interested in these changes to get OOTB daemon support. Think I found a typo.

@mckaygerhard
Copy link
Author

I too am interested in these changes to get OOTB daemon support. Think I found a typo.

yes.. but author and owner still are lazy on the repos.. i requested him to delegate to the others two more active users to aprove and manage commits by PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to run at startup / restart
4 participants