Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing docker example command for latest alpine image #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

psolru
Copy link

@psolru psolru commented May 16, 2022

While checking out filebrowser, I just noticed the database file is in the latest version of the alpine image in the same location as for the non-alpine image.
/database/filebrowser.db

This simply adjusts the example docker run command of the install docs

Fixing docker example command for alpine image
@slinkytoad
Copy link

I just got stumped by this. Would be nice to have the PR merged to update the docs.

@o1egl
Copy link
Member

o1egl commented Jul 22, 2023

That is not correct. The default config file for docker points to the /filebrowser.db

@o1egl o1egl added the invalid This doesn't seem right label Jul 22, 2023
@HackintoshwithUbuntu
Copy link

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

@o1egl
Copy link
Member

o1egl commented Dec 6, 2023

That is not correct. The default config file for docker points to the /filebrowser.db

The default config points to filebrowser.db but the docker command maps a file on the local filesystem called filebrowser.db to one on the docker container's file system called database.db

To fix this we can either update the default config to expect a file called "database.db" or do what this PR suggested and update the docker command so that a file called "filebrowser.db" appears on the container file system

For what its worth, my install on docker did not work out of the box and these fixes were required.

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

@HackintoshwithUbuntu
Copy link

HackintoshwithUbuntu commented Dec 7, 2023

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

@o1egl
Copy link
Member

o1egl commented Dec 28, 2023

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

@HackintoshwithUbuntu
Copy link

I'm not sure I'm following you. This is the default database path https://github.com/filebrowser/filebrowser/blob/master/docker_config.json#L6C30-L6C30

I think the confusion is arising because we are referencing two different files.

  1. I was talking about https://github.com/filebrowser/filebrowser/blob/master/docker/root/defaults/settings.json which is listed on the official installation guide here
  2. In the previous comment you have linked https://github.com/filebrowser/filebrowser/blob/master/docker_config.json

I think you would probably have a more in-depth knowledge than me about which file is actually being used

You are referrencing a linuxserver based image config, but actually changing a regular docker file. It uses docker_config.json which points to the /database.db

My apologies, I understand now. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants