Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No repay debt requirement for DeclareFaultsRecovered #20

Merged
merged 5 commits into from
Oct 29, 2020

Conversation

irenegia
Copy link
Contributor

Remove the requirement to repay debt from DeclareFaultsRecovered.

FIPS/fip-000x.md Outdated Show resolved Hide resolved
@zixuanzh
Copy link
Contributor

There is a potential product concern here which is that the protocol does want miners to recover as soon as possible. However, I still think this FIP is fine because the penalty stops when the miner has recovered the data and hence there is still guarantee to the storage client even though the miner may not be able to produce blocks until debt is paid. cc @pooja

@momack2
Copy link
Contributor

momack2 commented Oct 26, 2020

I don't think your logic lines up here, @zixuanzh. The protocol wants the miner to recover their sectors as soon as possible - however blocking the miner on declaring the recovery due to a debt actually makes that much harder - increasing the chances the miner ends up in a downward spiral that causes them to lose all deals/sectors. Landing this FIP makes it easier for miners to recover their sectors and repay a more manageable debt (which they are still highly incentivized to do) - increasing storage performance overall.

FIPS/fip-000x.md Outdated Show resolved Hide resolved
FIPS/fip-000x.md Outdated Show resolved Hide resolved
@momack2 momack2 merged commit 091bc5d into filecoin-project:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants