Simplify aggregate verification #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Oct 17, 2023
| // zero key & single hash should fail | ||
| if n_hashes == 1 && public_keys[0].0.is_identity().into() { | ||
| // zero keys should always fail. | ||
| if public_keys.iter().any(|pk| pk.0.is_identity().into()) { |
There was a problem hiding this comment.
There's no reason to not check these up-front. We could check them in parallel later, but we already have an n^2 loop so this shouldn't have an appreciable impact on performance. Really, dropping the atomics will likely increase performance (even when taking relaxed ordering into account).
| if res.is_err() { | ||
| valid = false; | ||
| break; | ||
| if pairing |
There was a problem hiding this comment.
I'm really not sure why the previous code was written with the valid boolean that way.
There was a problem hiding this comment.
Yeah, it;'s definitely goofy. I'm guessing that this function was originally using combinators rather than for loops.
Stebalien
force-pushed
the
steb/remove-atomic
branch
from
6dc60e3
to
b408255
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Stebalien
force-pushed
the
steb/remove-atomic
branch
from
8962922
to
b408255
Compare
vmx
reviewed
Oct 18, 2023
There was a problem hiding this comment.
LGTM, but I'd like to have another pair of eyes on it (@DrPeterVanNostrand maybe?).
Mostly remove all cases where we'd need to track a "valid" boolean and/or atomic: - Check that all there are no zero keys up-front in `verify`. - Use fallible mapping/reducing in `verify_message` instead of a "valid" boolean. - Use rayon's "reduce with" feature which should allow parallel processing?
Stebalien
force-pushed
the
steb/remove-atomic
branch
from
b408255
to
19d735a
Compare
DrPeterVanNostrand
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly remove all cases where we'd need to track a "valid" boolean and/or atomic:
verify.verify_messageinstead of a "valid" boolean.This patch isn't necessary in any way, I just wrote it as I reviewed the code. I figured I'd submit it as it does simplify things a bit, IMO.