Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devnet images using Lotus from DockerHub #1157

Merged
merged 2 commits into from
Feb 15, 2023

Conversation

airenas
Copy link
Contributor

@airenas airenas commented Feb 3, 2023

Implemented as requested in (#1084).
Now building images the first time for devnet should be twice faster.

Changes

  • tested with an official lotus image: v1.19.0-debug. The image works out of the box, without any other changes
  • updated Makefile to use the official lotus docker image instead of building locally as the default case
  • refactored makefile to use a new lotus dockerfile, but rollbacked. The tag 1.19.0 (default now) of the lotus repo does not contain the new Dockerfile, so the building did not work out-of-the-box
  • updated readme

Options to prepare devnet images

with the official lotus image

Works only for amd64 platforms

make docker/all
# with another image, e.g.: filecoin/lotus-all-in-one:nightly-debug
make docker/all lotus_version=nightly

with specific version of lotus

make docker/all lotus_version=v1.17.0 build_lotus=1
# for M1, M2
make docker/all lotus_version=v1.17.0 build_lotus=1 ffi_from_source=1

from lotus source

make docker/all lotus_src_dir=../lotus

@airenas airenas changed the title Lotus from dockerhub Devnet images using Lotus from DockerHub Feb 3, 2023
@jacobheun
Copy link
Contributor

I was able to do the make build with the latest 1.20.0-rc1 from lotus and that was much quicker (I'm using AMD). When I ran docker compose up -d everything got stuck in Starting. I'll try this again later today, might have just been an issue with my setup.

Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the issue I was having earlier I believe was due to recent changes in the lotus 1.20.0-rc1. I was able to run this against 1.19.0 without any issues.

@jacobheun jacobheun merged commit 1810bcd into filecoin-project:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants