fix homedir expansion #1231
Merged
fix homedir expansion #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
commented
Feb 28, 2023
| if err != nil { | ||
| return nil, fmt.Errorf("expanding homedir: %w", err) | ||
| } | ||
|
|
||
| node, err := clinode.Setup(cfgdir) |
There was a problem hiding this comment.
cfgdir is expanded within clinode.Setup, but it is also currently used in non-expanded form further down in this function at:
fc, err := rc.NewClient(node.Host, api, node.Wallet, addr, bstore, ds, cfgdir)
So this PR is expanding the cfgdir immediately when we get it from the flag.
LexLuthr
approved these changes
Feb 28, 2023
nonsense
force-pushed
the
nonsense/fix-retrieve-cmd-homedir-expansion
branch
from
4ca5842 to
c4e9f46
Compare
dirkmc
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.