Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing libp2p-go-eventbus #1302

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

brossetti1
Copy link
Contributor

@brossetti1 brossetti1 commented Mar 17, 2023

Problem

#1303

github.com/libp2p/go-eventbus is deprecated and should boost should be using github.com/libp2p/go-libp2p/p2p/host/eventbus instead.

Solution

  • updating the packages from github.com/libp2p/go-eventbus to github.com/libp2p/go-libp2p/p2p/host/eventbus
  • call go mod tidy
  • confirmed build worked

related to boost dependency blockers in data-preservation-programs/ValidationBot#36

Description

this helps with removing references to go-libp2p-core in dependencies:

> go mod graph | grep libp2p-core

....
github.com/libp2p/go-eventbus@v0.2.1 github.com/libp2p/go-libp2p-core@v0.5.7
....

@brossetti1 brossetti1 changed the title removing libp2p- go-eventbus removing libp2p-go-eventbus Mar 17, 2023
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@dirkmc dirkmc merged commit f3622c8 into filecoin-project:main Mar 20, 2023
@dirkmc dirkmc mentioned this pull request Mar 20, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants