v1.0.0/filclient-commp-fix branch + patch #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: #673 (comment) Ideally we can remove go-merkledag entirely from here because most (all?) of the deal-making infrastructure uses go-codec-dagpb + go-ipld-prime traversals and post-decode link-reordering is a subtle difference that impacts CAR ordering for non-spec-compliant DAG-PB blocks.
rvagg
added a commit
to application-research/filclient
that referenced
this pull request
Aug 3, 2022
Ref: filecoin-project/boost#680 Fixes the CommP mismatch problems with the CAR being generated out of order for DAGs with certain (slightly) malformed DAG-PB blocks.
nonsense
changed the title
|
This has been tagged in https://github.com/filecoin-project/boost/releases/tag/v1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the two commits from #675 but is branched off
v1.0.0, the intention with this is to get https://github.com/application-research/filclient updated with v1.0.0 as it's currently relying on cd38741 but I think pulling it to v1.0.0 won't be too traumatic. We'll see, we might have to pull the branch back a bit to not make it too big a jump.