-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libp2p retrieval transports endpoint #723
Conversation
57db571
to
08d341e
Compare
0c4a1cd
to
cf19ff6
Compare
cf19ff6
to
7942c6e
Compare
b32c4b7
to
b13921a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent. Left a single comment regarding a... comment.
@@ -3,7 +3,8 @@ | |||
type Multiaddr bytes | |||
|
|||
type Protocol struct { | |||
# The name of the transport protocol eg "libp2p" or "http" | |||
# The name of the transport protocol | |||
# Known protocols: "libp2p", "http", "https" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dirkmc @hannahhoward where does libp2p-http
fit in this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently libp2p-http
is only used for storage deals
Fixes #717
TODO: