Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libp2p retrieval transports endpoint #723

Merged
merged 4 commits into from
Aug 24, 2022
Merged

libp2p retrieval transports endpoint #723

merged 4 commits into from
Aug 24, 2022

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Aug 22, 2022

Fixes #717

TODO:

  • Change Protocol Endpoint field to an array of multi-addresses
  • Implement CLI command to make libp2p query to endpoint
$ boost provider retrieval-transports t01000
libp2p
  /ip4/192.168.1.11/tcp/50000
  /ip4/127.0.0.1/tcp/50000
  /ip6/::1/tcp/65450
http
  /dns/foo.com/tcp/443/https
    https://foo.com:443

$ boost --json provider retrieval-transports t01000
{
  "http": [
    {
      "multiaddr": "/dns/foo.com/tcp/443/https",
      "address": "https://foo.com:443"
    }
  ],
  "libp2p": [
    {
      "multiaddr": "/ip4/192.168.1.11/tcp/50000"
    },
    {
      "multiaddr": "/ip4/127.0.0.1/tcp/50000"
    },
    {
      "multiaddr": "/ip6/::1/tcp/65450"
    }
  ]
}

@dirkmc dirkmc force-pushed the feat/retrieval-tspts branch from 57db571 to 08d341e Compare August 22, 2022 14:57
node/config/doc_gen.go Outdated Show resolved Hide resolved
@dirkmc dirkmc force-pushed the feat/retrieval-tspts branch from 0c4a1cd to cf19ff6 Compare August 23, 2022 07:29
@dirkmc dirkmc force-pushed the feat/retrieval-tspts branch from cf19ff6 to 7942c6e Compare August 23, 2022 07:36
@dirkmc dirkmc force-pushed the feat/retrieval-tspts branch from b32c4b7 to b13921a Compare August 23, 2022 10:38
@dirkmc dirkmc marked this pull request as ready for review August 23, 2022 10:42
Copy link
Contributor

@ribasushi ribasushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks excellent. Left a single comment regarding a... comment.

retrievalmarket/types/transports.ipldsch Show resolved Hide resolved
@dirkmc dirkmc merged commit edfaf9f into main Aug 24, 2022
@dirkmc dirkmc deleted the feat/retrieval-tspts branch August 24, 2022 07:57
@@ -3,7 +3,8 @@
type Multiaddr bytes

type Protocol struct {
# The name of the transport protocol eg "libp2p" or "http"
# The name of the transport protocol
# Known protocols: "libp2p", "http", "https"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkmc @hannahhoward where does libp2p-http fit in this scenario?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently libp2p-http is only used for storage deals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libp2p endpoint that lists supported transport protocols
3 participants