Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant VerifyDealsForActivation call in ProveReplicaUpdates #1308

Closed
anorth opened this issue Jun 2, 2023 · 1 comment · Fixed by #1361
Closed

Avoid redundant VerifyDealsForActivation call in ProveReplicaUpdates #1308

anorth opened this issue Jun 2, 2023 · 1 comment · Fixed by #1361

Comments

@anorth
Copy link
Member

anorth commented Jun 2, 2023

ProveReplicaUpdates both activates deals and then (afterwards!) invokes VerifyDealsForActivation in order to retrieve the (computed) sector data commitments. This involves two call overheads, and loading the deals from state twice.

Combine these into one call by returning all necessary information from ActivateDeals.

@anorth
Copy link
Member Author

anorth commented Aug 6, 2023

We probably want a flag for ActivateDeals specifying whether to compute CommD, because it's needed only for replica update, not prove-commit (where CommD is already known).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants