refactor replica updates to use the batched activation and claim method #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
anorth
approved these changes
Jun 2, 2023
|
|
||
| // Errors past this point cause the prove_replica_updates call to fail (no more skipping sectors) | ||
| let deal_data = request_deal_data(rt, §ors_deals)?; |
There was a problem hiding this comment.
I've opened #1308 to follow up on removing this (after the other optimisations you are pursuing).
test_vm/tests/replica_update_test.rs
Outdated
| @@ -1080,6 +1080,8 @@ fn deal_included_in_multiple_sectors_failure_test<BS: Blockstore>(v: &dyn VM<BS> | |||
| // make some unverified deals | |||
| let deal_ids = create_deals_frac(2, v, worker, worker, maddr, 2, false, 180 * EPOCHS_IN_DAY); | |||
|
|
|||
| println!("deals {:?}", deal_ids); | |||
alexytsu
force-pushed
the
alexytsu/1306-replica-update-batched-activations
branch
from
b277264
to
affa578
Compare
alexytsu
added a commit
that referenced
this pull request
Jun 5, 2023
* miner batch claim of datacap allocations in confirm_sector_proofs_valid_internal * fix expectations * move test util into test code * verifreg nits * factor batch activate deals and claim allocations for reuse in replica_updates * update docs * fix regression * PR review * remove superfluous BatchReturn info * refactor replica updates to use the batched activation and claim method (#1307)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1306