EVM: Pad output of resolve_address #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1005 +/- ##
==========================================
+ Coverage 85.56% 88.43% +2.86%
==========================================
Files 127 127
Lines 24032 23574 -458
==========================================
+ Hits 20564 20847 +283
+ Misses 3468 2727 -741
|
2 tasks
raulk
approved these changes
Jan 10, 2023
Comment on lines
118
to
+119
| /// Read BE encoded low u64 ID address from a u256 word | ||
| /// Looks up and returns the encoded f4 addresses of an ID address, returning empty array if not found | ||
| /// Looks up and returns the encoded f4 addresses of an ID address. Empty array if not found or `InvalidInput` input was larger 2^64. |
There was a problem hiding this comment.
Is this the final form of the docs? They look a little bit unstructured. Would suggest to:
- Explain what these methods do on a conceptual level.
- Then specify the call layout in a way similar to what I did in FIP-0054.
- Then specify the return value.
- Then specify the errors.
Can fix in a follow-up PR.
There was a problem hiding this comment.
Issue that covers this: filecoin-project/ref-fvm#1432
| /// returns BE encoded u64 or empty array if nothing found | ||
| /// Reads a FIL encoded address. | ||
| /// Resolves a FIL encoded address into an ID address. | ||
| /// Returns BE encoded u256 (return will always be under 2^64). Empty array if nothing found or `InvalidInput` if length was larger 2^32. |
There was a problem hiding this comment.
Since we mix up two forms of padding (right padding and left padding) in the precompiles, it wouldn't hurt to specify which kind of padding we use here (left/natural padding).
There was a problem hiding this comment.
will fix in follow up PR to get @emmanuelm41 unblocked ASAP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.