EVM: Improve the call tests #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Jan 13, 2023
actors/evm/tests/call.rs
Outdated
| push1 0x00 | ||
| push1 0x00 | ||
| push1 0x00 # offset | ||
| push1 0x01 # dest offset |
There was a problem hiding this comment.
first byte is the exit code pushed put into memory
There was a problem hiding this comment.
^what melanie said -- i can add comments making clear.
actors/evm/tests/call.rs
Outdated
| # return | ||
| returndatasize | ||
| returndatasize | ||
| push1 0x01 |
mriise
reviewed
Jan 13, 2023
Comment on lines
+406
to
+409
| # write exit code memory | ||
| push1 0x00 # offset | ||
| mstore8 | ||
|
|
mriise
reviewed
Jan 13, 2023
* Don't use the same methodNum as expected return data to avoid confusion * Include the success/failure of the call in the return data * Take methodNum and expected success as parameters for more extensible tests
arajasek
force-pushed
the
asr/call-tests
branch
from
74d75f1
to
9723d72
Compare
mriise
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would likely be worth applying these improvements to the other tests in the file too, but we're sprinting right now.