Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: drop unused exit() #1162

Merged
merged 1 commit into from
Feb 7, 2023
Merged

runtime: drop unused exit() #1162

merged 1 commit into from
Feb 7, 2023

Conversation

arajasek
Copy link
Contributor

@arajasek arajasek commented Feb 3, 2023

I love negative lines of code.

@arajasek arajasek requested review from vyzo and mriise February 3, 2023 15:13
@codecov-commenter
Copy link

Codecov Report

Merging #1162 (5ec2d30) into next (6540db3) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1162      +/-   ##
==========================================
+ Coverage   81.81%   81.84%   +0.03%     
==========================================
  Files         131      131              
  Lines       26559    26572      +13     
==========================================
+ Hits        21728    21749      +21     
+ Misses       4831     4823       -8     
Impacted Files Coverage Δ
runtime/src/runtime/mod.rs 48.97% <ø> (ø)
runtime/src/test_utils.rs 63.74% <0.00%> (+0.47%) ⬆️
test_vm/src/lib.rs 62.40% <100.00%> (-0.85%) ⬇️
actors/power/src/lib.rs 83.58% <0.00%> (+0.21%) ⬆️
state/src/check.rs 86.35% <0.00%> (+0.26%) ⬆️
...ors/evm/src/interpreter/instructions/arithmetic.rs 92.18% <0.00%> (+0.52%) ⬆️
actors/miner/src/deadline_info.rs 96.62% <0.00%> (+16.85%) ⬆️

Copy link
Contributor

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dunno, we might want to use it one day...

@Stebalien
Copy link
Member

@vyzo right now, the priority right now is merging to master and this code is unused and untested. If we do need it, we can always add it back (asr/runtime-exit)

@arajasek arajasek merged commit 267e833 into next Feb 7, 2023
@arajasek arajasek deleted the asr/drop-exit branch February 7, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants