EVM: Code tests #1181
Merged
EVM: Code tests #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Feb 8, 2023
| let result = m.step(); | ||
| assert!(result.is_ok(), "execution step failed"); | ||
| assert_eq!(m.state.stack.len(), 0); | ||
| assert_eq!(m.state.memory[0..3], m.bytecode[1..4]); |
There was a problem hiding this comment.
Can we test that that last byte is zero?
| } | ||
|
|
||
| #[test] | ||
| fn test_codecopy_oob() { |
There was a problem hiding this comment.
Can we test fully OOB? I.e., start OOB, start at the end, etc.?
| } | ||
|
|
||
| #[test] | ||
| fn test_codecopy_partial() { |
| } | ||
|
|
||
| #[test] | ||
| fn test_extcodecopy_partial() { |
There was a problem hiding this comment.
ditto above. Copy nothing should work.
| } | ||
|
|
||
| #[test] | ||
| fn test_extcodecopy_oob() { |
There was a problem hiding this comment.
Ditto above. Try starting past the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes filecoin-project/ref-fvm#1552
CODESIZECODECOPYEXTCODESIZEEXTCODECOPYEXTCODEHASH