-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVM: lifecycle tests #1185
EVM: lifecycle tests #1185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure the nonce is incremented.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1185 +/- ##
==========================================
+ Coverage 90.61% 90.78% +0.17%
==========================================
Files 132 132
Lines 25992 26313 +321
==========================================
+ Hits 23552 23888 +336
+ Misses 2440 2425 -15
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one small change.
} | ||
m.state.stack.push(beneficiary.as_evm_word()).unwrap(); | ||
m.step().expect("execution step failed"); | ||
assert!(m.system.tombstone.is_some()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's check the epoch/origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done; mock runtime always returns 0 for nonce, but I did set the origin and it stuck around as it should.
Closes filecoin-project/ref-fvm#1547
CREATE
CREATE2
SELFDESTRUCT