chore: merge master into next #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* S1: Perform AuthenticateMessage checks before stateful validation * S2: Call AuthenticateMessage in read_only mode * S4: Any failures in calls to MarketNotifyDeal fail the entire PSD * Add a test for NotifyDeal failure * Update actors/market/src/lib.rs Co-authored-by: Steven Allen <steven@stebalien.com> --------- Co-authored-by: Steven Allen <steven@stebalien.com>
Co-authored-by: zenground0 <ZenGround0@users.noreply.github.com>
Update lib.rs
* FIP-0054: Introduce the EVM actor's logic Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: vyzo <vyzo@hackzen.org> Co-authored-by: Melanie Riise <me@mriise.net> Co-authored-by: Raúl Kripalani <raul@protocol.ai> * Address review * Refactor imports, move EVM method types to types * README: Add note about EVM precompile license * EVM: use blake2f from parity's frontier (#1191) That way, we: 1. Don't depend on a fork of an unmaintained library. 2. Use a much simpler blake2f implementation. * chore: document precompile test data * Runtime: fix chain_id comment --------- Co-authored-by: Steven Allen <steven@stebalien.com> Co-authored-by: vyzo <vyzo@hackzen.org> Co-authored-by: Melanie Riise <me@mriise.net> Co-authored-by: Raúl Kripalani <raul@protocol.ai>
raulk
approved these changes
Feb 10, 2023
| @@ -70,7 +70,7 @@ pub enum Method { | |||
| DestroyExported = frc42_dispatch::method_hash!("Destroy"), | |||
| NameExported = frc42_dispatch::method_hash!("Name"), | |||
| SymbolExported = frc42_dispatch::method_hash!("Symbol"), | |||
| GranularityExported = frc42_dispatch::method_hash!("GranularityExported"), | |||
| GranularityExported = frc42_dispatch::method_hash!("Granularity"), | |||
There was a problem hiding this comment.
Uh, that's going to be a breaking change for Hyperspace. Hopefully nobody is relying on this method. We will note it in the release notes // cc @jennijuju @maciejwitowski We will need to propagate this change to the Solidity libraries too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.