market: Avoid re-using state between transactions #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup on #1220, but for the market actor. This doesn't actually change behavior, just makes it easy to verify that there's no reentrancy. Unfortunately, we can't use a single transaction in PublishStorageDeals because _that_ method looks up datacap balances after reading the state (see #1124, #1124).
Stebalien
force-pushed
the
steb/improve-market-transactions
branch
from
0d4a18c
to
8810678
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1221 +/- ##
==========================================
- Coverage 90.98% 90.94% -0.04%
==========================================
Files 133 133
Lines 26678 26677 -1
==========================================
- Hits 24272 24261 -11
- Misses 2406 2416 +10
|
Stebalien
requested review from
anorth and
ZenGround0
and removed request for
anorth
anorth
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #1220, but for the market actor. This doesn't actually change behavior, just makes it easy to verify that there's no reentrancy.
Unfortunately, we can't use a single transaction in PublishStorageDeals because that method looks up datacap balances after reading the state (see #1124, #1124).