Cache precommit state and use the cache state to expire all precommits in the proving deadline cron job #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZenGround0
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
This looks great. I'd love to see an empirical measurement of gas reduction. Doing this in an integration test is probably too much effort but it should be within reach to set up a 2k devent, precommitted many sectors, let them expire and then measure cron gas on expiry before and after this change (tools here should help: https://github.com/FILCAT/gas-model/tree/main).
I suspect you will see really good numbers so it might be worth taking the extra time to demonstrate how much compute you are saving everyone with this change.
anorth
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1426.
See Idea: fix non caching mistake in filecoin-project/FIPs#771.