Move QuantSpec into the miner actor #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, I had to duplicate a little bit of code in the market actor, but I think it's better to do that than to put this mostly miner specific logic in, e.g., the runtime.
rvagg
reviewed
Feb 9, 2024
Comment on lines
+1553
to
+1554
| // Same logic as QuantSpec from the miner actor, but duplicated here to avoid unnecessary | ||
| // dependencies. |
There was a problem hiding this comment.
we don't have a logical shared place over here to put this so we can dedupe? fil_actors_runtime?
There was a problem hiding this comment.
because actors/miner/src/quantize.rs isn't a whole lot more than this logic
There was a problem hiding this comment.
IMO, it's not worth it. Honestly, I'd like to trim down the runtime as well if possible (kind of a grab-bag at this point).
rvagg
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, I had to duplicate a little bit of code in the market actor, but I think it's better to do that than to put this mostly miner specific logic in, e.g., the runtime.