Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: miner: add niporep params cbor forms vector tests #1543

Closed
wants to merge 2 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 24, 2024

This works agains #1537 but since that's coming from a fork and I only want to have a single commit here I'm including it as if it compiles and tests. It can be reconciled in some form later but for now I just want to get matching go-state-types implementations and tests.

Depends on

Preview Give feedback
  1. rvagg
  2. 4 of 4
    rjan90

@rvagg
Copy link
Member Author

rvagg commented May 24, 2024

Matching go-state-types params implementation and tests @ filecoin-project/go-state-types#270

@rvagg rvagg force-pushed the rvagg/niporep-params-encoding branch from 8cd4e74 to 0a2af37 Compare June 11, 2024 11:18
@rvagg
Copy link
Member Author

rvagg commented Jun 11, 2024

Updated to match FIP-0092 changes, but this depends on filecoin-project/ref-fvm#2010 and released ref-fvm and it being updated in the helix-onchain crates too, so for now they are path dependencies.

@rvagg rvagg force-pushed the rvagg/niporep-params-encoding branch 3 times, most recently from 57bd35c to 3bd66ea Compare June 18, 2024 00:17
@rvagg rvagg force-pushed the rvagg/niporep-params-encoding branch from 3bd66ea to c797476 Compare June 18, 2024 00:21
@rvagg
Copy link
Member Author

rvagg commented Jun 18, 2024

Cargo.toml, Cargo.lock and actors/miner/src/types.rs are all now identical to #1537, so this PR will just add the tests on top of that when it lands.

@rvagg rvagg mentioned this pull request Jun 25, 2024
@rvagg
Copy link
Member Author

rvagg commented Jun 25, 2024

landed in master in #1559

@rvagg rvagg closed this Jun 25, 2024
@rvagg rvagg deleted the rvagg/niporep-params-encoding branch June 25, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant