Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: miner: max prove commit sector batch size #1544

Closed
wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 25, 2024

The lack of a batch max size for the NI-PoRep method @ #1537 came up during an audit yesterday given that one is applied to precommit batches and it was noted that there's no max applied on prove_commit_sectors3, although there is one applied on aggregate proof size.

This may not be necessary here since I suppose it's already limited by the precommit limit, but I wanted to check whether that's correct or not. Perhaps the limitation imposed in this PR should only be added to #1537 for the reason documented @

// 32 sectors per epoch would support a single miner onboarding 1EiB of 32GiB sectors in 1 year.
pub const PRE_COMMIT_SECTOR_BATCH_MAX_SIZE: usize = 256;

@rvagg rvagg requested a review from anorth May 25, 2024 01:43
@anorth
Copy link
Member

anorth commented May 27, 2024

What we actually want to do is remove the pre-commit max batch size. #1268

@rvagg
Copy link
Member Author

rvagg commented May 28, 2024

ok, that's good to know; we can ignore this now but we should take this into account in #1537

@rvagg rvagg closed this May 28, 2024
@rvagg rvagg deleted the rvagg/max-prove-commit branch May 28, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants