feat: miner: max prove commit sector batch size #1544
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of a batch max size for the NI-PoRep method @ #1537 came up during an audit yesterday given that one is applied to precommit batches and it was noted that there's no max applied on prove_commit_sectors3, although there is one applied on aggregate proof size.
This may not be necessary here since I suppose it's already limited by the precommit limit, but I wanted to check whether that's correct or not. Perhaps the limitation imposed in this PR should only be added to #1537 for the reason documented @
builtin-actors/runtime/src/runtime/policy.rs
Lines 241 to 242 in 2899d1b