doc(miner): minor correction to aggregate fee comment in PCS3 #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
approved these changes
Jun 3, 2024
rvagg
commented
Jun 4, 2024
anorth
approved these changes
Jun 6, 2024
ZenGround0
pushed a commit
that referenced
this pull request
Jun 25, 2024
* doc(miner): correction to aggregate fee comment in PCS3 * Update actors/miner/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NemanjaLu92 pointed out that aggregate fee is paid after activations while discussing the need for this for the NI-PoRep method, so this comment was likely incorrect in
prove_commit_sectors3. I thought this was worth checking with a isolated PR since it should be relatively straightforward to clarify.