fix: restore ConfirmSectorProofsValid #1553
Conversation
removed in #1540 but still needed to activate preseals
There was a problem hiding this comment.
@aarshkshah1992 has looked into the lotus seed usage and found that we will need significant FVM work to move away from CSPV for preseal activation. For expediancy we can keep a simplified version of CSPV. I'll file an issue to do the correct thing and get rid of this code in the future.
|
@ZenGround0 @rvagg Should we merging this to the release/v14 branch instead ? |
|
I haven't been so involved in the v14 release but the typical thing we've done here is merge changes to master first and then cherrypick them to the release branch. |
@ZenGround0 : please paste a link to that issue when you have it - thanks. |
|
@aarshkshah1992 or @ZenGround0 : as part of filecoin-project/lotus#12132, can we get an approval on this change? |
|
Oh sorry, I realize @ZenGround0 alraedy gave an approval. @aarshkshah1992 : are you ok to merge? |
* fix: restore ConfirmSectorProofsValid removed in #1540 but still needed to activate preseals * changes as per review * make rustfmt --------- Co-authored-by: aarshkshah1992 <aarshkshah1992@gmail.com>
Removed in #1540 but I believe it's still needed to activate preseals; unless there's an alternative route to this?
Ref: https://github.com/filecoin-project/lotus/blob/b73d4e0481517b395a0e9aa9af5dab8bedc18285/chain/gen/genesis/miners.go#L494-L509
Tests for this were tangled up in the prove commit + cron stuff that was removed, this probably needs new tests if it's going back, but I'm not sure yet what that would entail.