Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick NI-PoRep commit from master to reflect the V14 RC #1562

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

aarshkshah1992
Copy link
Contributor

No description provided.

rvagg and others added 2 commits June 25, 2024 13:11
* feat(miner): ProveCommitSectorsNI and tests

* chore(niporep): fix parameter naming

* chore(niporep): improve test function name

* chore(niporep): check return values from method

* fix(niporep): hard-fail on future sector seal randomness

* fix(niporep): properly test aggregate fee payment at boundary

* test(miner): add niporep params cbor forms vector tests

* chore(miner): extract NI_AGGREGATE_FEE_BASE_SECTOR_COUNT constant

---------

Co-authored-by: Nemanja <7816150+NemanjaLu92@users.noreply.github.com>
@aarshkshah1992 aarshkshah1992 requested a review from rvagg June 25, 2024 09:14
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine, but I suggest just deleting release/v14 since there are no tags on it and re-creating it from master to avoid all of this and the merge commit already on there

@aarshkshah1992
Copy link
Contributor Author

Hmm. branch protections on this repo are not allowing me to do it.

@aarshkshah1992
Copy link
Contributor Author

Can't reset the branch to just reflect what's on master and force push either.

@aarshkshah1992 aarshkshah1992 merged commit 9115c8b into release/v14 Jun 25, 2024
14 checks passed
@aarshkshah1992 aarshkshah1992 deleted the chore/cherry-pick-v14-rc-commits branch June 25, 2024 09:22
@aarshkshah1992
Copy link
Contributor Author

@rvagg Have asked around offline to see who has the perms to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants