Use ActorID rather than addresses in new verifreg state #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
force-pushed
the
anorth/ids-in-state
branch
from
2461610
to
af849ef
Compare
ZenGround0
approved these changes
Sep 9, 2022
|
Nope you did this |
anorth
force-pushed
the
anorth/ids-in-state
branch
from
af849ef
to
e9f6306
Compare
anorth
force-pushed
the
anorth/ids-in-state
branch
from
e9f6306
to
b2bfcbf
Compare
shamb0
pushed a commit
to shamb0/builtin-actors
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed.
In this PR I haven't also migrated the
verifiersmap to be keyed by actor ID. This would require a migration, but a small one and we're touching this actor anyway. LMK whether you think I should do that, and if so in this PR or a follow-up.