feat: index provider #182
Merged
feat: index provider #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
force-pushed
the
feat/index-provider
branch
from
6db560e to
3d82c0c
Compare
gammazero
reviewed
Aug 30, 2024
LexLuthr
force-pushed
the
market-migration
branch
from
5a4eda5 to
1ac908f
Compare
magik6k
reviewed
Sep 4, 2024
magik6k
reviewed
Sep 17, 2024
|
|
||
| func (p *Provider) GetEntry(block cid.Cid, provider string) ([]byte, error) { | ||
| // We should use background context to avoid early exit | ||
| // while chunking as first attempt will always fail |
| db *harmonydb.DB | ||
| pieceProvider *pieceprovider.PieceProvider | ||
| entriesChunker *chunker.Chunker | ||
| cache *lru.Cache[ipld.Link, datamodel.Node] |
There was a problem hiding this comment.
Can we get rid of this cache and build/stream entries on the fly?
LexLuthr
force-pushed
the
feat/index-provider
branch
from
b2f25ed to
4d22e9a
Compare
magik6k
reviewed
Sep 17, 2024
| CREATE INDEX ipni_provider_ad_cid ON ipni(provider, ad_cid); | ||
|
|
||
|
|
||
| CREATE TABLE ipni_head ( |
There was a problem hiding this comment.
TODO (me): Maybe this doesn't need to exist and can just be max(ipni.order_number)
magik6k
reviewed
Sep 17, 2024
| // corresponding CAR offset. The order is maintained consistently regardless of | ||
| // the underlying IterableIndex implementation. Returns error if duplicate | ||
| // offsets detected. | ||
| func CarMultihashIterator(idx index.IterableIndex) (*SliceMhIterator, error) { |
There was a problem hiding this comment.
TODO (me): Kill this with fire
magik6k
reviewed
Sep 17, 2024
There was a problem hiding this comment.
TODO (me): Seems like this snuck back into here again
magik6k
approved these changes
Sep 17, 2024
|
FYI: I am working on a FRC to document the Retrieval Checking Requirements, see filecoin-project/FIPs#1089 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks IPNI advertisement and publishing into separate modules. If IPNI is enabled: