Remove file on storage termination #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recover hard drive space once a storage deal terminates by deleting the generated file
willscott
approved these changes
Jun 15, 2021
hannahhoward
force-pushed
the
feat/remove-file-on-deal-termination
branch
from
56af71f to
88c0bc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
recover hard drive space once a storage deal terminates by deleting the generated file
Implementation
This is definitely a minimal approach, but it should get the job done -- just delete the generated file when the storage deal finishes executing, and clear the Lotus import
For discussion
For a succesful deal, this won't delete until the deal goes to StorageDealActive, which can be a long time. Technically, we could delete it sooner. Is it important to add code to check for the state when the data transfer is open and delete it then (StorageDealCheckForAcceptance)