Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pq to resolve concurrent map issue #329

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

hannahhoward
Copy link
Contributor

Goals

We're getting crashes on the Dealbot due to a concurrent map write that appears in the PQ code.

Fortunately, it appears a fix was deployed in an update to pq

Implementation

Update PQ.

For Discussion

Our stack trace:


goroutine 3340 [running]:
runtime.throw(0x3bf7250, 0x15)
	/usr/local/go/src/runtime/panic.go:1117 +0x72 fp=0xc001043cf8 sp=0xc001043cc8 pc=0x1166332
runtime.mapdelete_faststr(0x37fb940, 0xc0005e3ec0, 0x3bd9717, 0x9)
	/usr/local/go/src/runtime/map_faststr.go:306 +0x3de fp=0xc001043d60 sp=0xc001043cf8 pc=0x1142a9e
github.com/lib/pq.ssl(0xc0005e3ec0, 0x10, 0xc000902cc0, 0x7fa0746eb218)
	/go/pkg/mod/github.com/lib/pq@v1.10.0/ssl.go:63 +0x178 fp=0xc001043dd0 sp=0xc001043d60 pc=0x1d42e18
github.com/lib/pq.(*conn).ssl(0xc000c96b00, 0xc0005e3ec0, 0x550e740, 0xc001058de0)

original PQ issue: lib/pq#1031

Fix PR in dep: lib/pq#1035

Copy link

@coryschwartz coryschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks for find this.

@hannahhoward hannahhoward merged commit 41c1fe4 into main Sep 14, 2021
@hannahhoward hannahhoward deleted the fix/broken-pq-dep branch September 14, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants