-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tmp prefix from tar path #158
Conversation
@cryptonemo @dignifiedquire @porcuquine could one of you please review this? |
This is straight-forward enough, but the hesitation is on whether there is tooling that depends on current behavior that may break after an update like this. |
We should inform the other implementer about this and see what their opinions are. |
Forest is not dependent on this. |
@arajasek could you please comment from the lotus' perspective? |
@turuslan Which project is using this extra scripting mentioned? It would be good to track specifically who/what this affects. |
I've seen that in this project's script - filecoin-ffi/install-filcrypto - and it should't affect it (because it uses |
Ok, thanks! |
Currently release tarballs contain temporary path in filenames.
It requires extra scripting to extract and use the files (e.g. using
find
).This PR suggests changes that make tarball paths clear and simple like