Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tmp prefix from tar path #158

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Remove tmp prefix from tar path #158

merged 1 commit into from
Apr 29, 2021

Conversation

turuslan
Copy link
Contributor

Currently release tarballs contain temporary path in filenames.
It requires extra scripting to extract and use the files (e.g. using find).

$ tar -tf <(curl -Ls https://github.com/filecoin-project/filecoin-ffi/releases/download/1d9cb3e8ff53f51f/filecoin-ffi-Darwin-standard-pairing.tar.gz)

var/folders/gk/lkr9pm5x039fx6d3j9r52rv80000gn/T/tmp.M9Jia6UQ/filcrypto.h
var/folders/gk/lkr9pm5x039fx6d3j9r52rv80000gn/T/tmp.M9Jia6UQ/filcrypto.pc
var/folders/gk/lkr9pm5x039fx6d3j9r52rv80000gn/T/tmp.M9Jia6UQ/libfilcrypto.a

This PR suggests changes that make tarball paths clear and simple like

filcrypto/filcrypto.h
filcrypto/filcrypto.pc
filcrypto/libfilcrypto.a

@jennijuju
Copy link
Member

@cryptonemo @dignifiedquire @porcuquine could one of you please review this?

@cryptonemo
Copy link
Contributor

This is straight-forward enough, but the hesitation is on whether there is tooling that depends on current behavior that may break after an update like this.

@jennijuju
Copy link
Member

We should inform the other implementer about this and see what their opinions are.

@jennijuju
Copy link
Member

We should inform the other implementer about this and see what their opinions are.

Forest is not dependent on this.

@jennijuju
Copy link
Member

@arajasek could you please comment from the lotus' perspective?

@cryptonemo
Copy link
Contributor

@turuslan Which project is using this extra scripting mentioned? It would be good to track specifically who/what this affects.

@turuslan
Copy link
Contributor Author

@turuslan Which project is using this extra scripting mentioned? It would be good to track specifically who/what this affects.

I've seen that in this project's script - filecoin-ffi/install-filcrypto - and it should't affect it (because it uses find anyway)

@cryptonemo
Copy link
Contributor

@turuslan Which project is using this extra scripting mentioned? It would be good to track specifically who/what this affects.

I've seen that in this project's script - filecoin-ffi/install-filcrypto - and it should't affect it (because it uses find anyway)

Ok, thanks!

@magik6k magik6k merged commit de19ffb into filecoin-project:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants