feat: add -Zfeatures=itarget to support conditional compilation of dependency feature based on target #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With RustCrypto/hashes#224 merged into sha-0.9.3, this is not needed anymore. |
…pendency feature based on target
|
I think this is fixed meanwhile, feel free to re-open if it's not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to filecoin-project/rust-fil-proofs#1404.
We want to enable the feature
compress, asmon aarch64 forsha2, while only enable featurecompressonx86.The
-Zfeatures=itargetis necessary for supporting conditional compilation of dependency feature based on target [1][2].[1] rust-lang/cargo#2524
[2] rust-lang/cargo#7914