fix: list GPU devices also with SupraSeal #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SupraSeal has it's own GPU device management. The rest of the system does *not* know, which GPUs will be used/are available. Though some code paths still use the usual Rust based code. Instead of returning no devices, the call to `get_gpu_devices` now returns all devices the Rust based system will use. It's not necessarily the same as SupraSeal will use.
vmx
force-pushed
the
gpu-report-supraseal
branch
from
962f32c
to
bfe319d
Compare
magik6k
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SupraSeal has it's own GPU device management. The rest of the system does not know, which GPUs will be used/are available. Though some code paths still use the usual Rust based code. Instead of returning no devices, the call to
get_gpu_devicesnow returns all devices the Rust based system will use. It's not necessarily the same as SupraSeal will use.