Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up deps #445

Merged
merged 1 commit into from
Dec 22, 2023
Merged

refactor: clean up deps #445

merged 1 commit into from
Dec 22, 2023

Conversation

vmx
Copy link
Contributor

@vmx vmx commented Dec 21, 2023

The byteorder crate isn't actually used.

Also remove the direct dependency on the fr32 crate, which was used for testing only anway. As fr32 is part of the proofs, this change should make upgrades easier, as now the FFI only depends on filecoin-proofs-api, which is the public API for proofs.

The `byteorder` crate isn't actually used.

Also remove the direct dependency on the `fr32` crate, which was used
for testing only anway. As `fr32` is part of the proofs, this change should
make upgrades easier, as now the FFI only depends on `filecoin-proofs-api`,
which is the public API for proofs.
@vmx vmx requested a review from cryptonemo December 21, 2023 13:03
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@Stebalien Stebalien merged commit 5834988 into master Dec 22, 2023
9 checks passed
@Stebalien Stebalien deleted the cleanup-deps-202312 branch December 22, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants