Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FVM, Deps & Rust #484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update FVM, Deps & Rust #484

wants to merge 2 commits into from

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Sep 13, 2024

  • Updates the FVM to v4.4.3, v3.11.1, and v2.9.1 in order to pull in the latest wasmtime (v25) version and the latest dependencies.
  • Update the rest of our dependencies (except those that have breaking changes, I'll do that in a separate PR).
  • Update rust to 1.78, the version used/tested in the FVM crate.

@@ -2068,7 +2068,6 @@ pub mod tests {
let f_new_sealed_sector = OpenOptions::new()
.read(true)
.write(true)
.create(true)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files already exist.

@ribasushi
Copy link
Contributor

cc @rjan90 @BigLep this one should make it to NV24
probably coupling with #486 makes sense

@Stebalien
Copy link
Member Author

I would ship this in the next feature release, but not in stable as it pulls in new wasmtime versions (risk) and fixes a long-standing bug that only affects macos.

@Stebalien
Copy link
Member Author

(although I'd still like to get it merged...)

@BigLep
Copy link
Member

BigLep commented Sep 17, 2024

Message received on the risk here of requiring this during a network upgrade without sufficient bake time in production beforehand. As a result, we'll include in v1.31.0.

This updates us to 1.78, the version the FVM is currently tested against.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants