Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rjan90 and rvagg to fvm-crate-owners #58

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

BigLep
Copy link
Member

@BigLep BigLep commented Aug 13, 2024

Summary

Added @rjan90 and @rvagg to fvm-crate-owners

Why do you need this?

This is being done because they're often involved in making releases as part of network upgrades.

Related

This was triggered when looking at the release process of actors-utils in filecoin-project/actors-utils#235 and ref-fvm in filecoin-project/ref-fvm#2027

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

This is being done because they're often involved in making releases as part of network upgrades.
Copy link
Contributor

The following access changes will be introduced as a result of applying the plan:

Access Changes
There will be no access changes

Copy link
Contributor

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

filecoin-project

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # github_team_membership.this["fvm-crate-owners:rjan90"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "5754561"
      + username = "rjan90"
    }

  # github_team_membership.this["fvm-crate-owners:rvagg"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = "5754561"
      + username = "rvagg"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

@BigLep BigLep requested a review from Stebalien August 13, 2024 21:43
@BigLep BigLep marked this pull request as ready for review August 13, 2024 21:44
@@ -5048,13 +5048,17 @@ teams:
- Kubuxu
- ZenGround0
fvm-crate-owners:
description: Defines ownership of various crates per
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galargh : I see this isn't applied via terraform. Is that a github-as-code deficiency or terraform? Should I create a backlog item?

@BigLep BigLep merged commit a04fdfb into master Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants