Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap correct FSM error when closing a channel #123

Merged
merged 1 commit into from
Dec 3, 2020
Merged

Wrap correct FSM error when closing a channel #123

merged 1 commit into from
Dec 3, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Dec 2, 2020

Summary

Fixing a typo, which caused the wrong error to be wrapped, preventing proper error inspection by callers

@ingar ingar requested a review from dirkmc December 2, 2020 20:41
@ingar ingar mentioned this pull request Dec 2, 2020
Merged
1 task
dirkmc
dirkmc approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@dirkmc dirkmc merged commit 0ecc981 into master Dec 3, 2020
@dirkmc dirkmc deleted the fix/return-wrapped-fsm-error branch December 3, 2020 09:14
This was referenced Dec 8, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingar @dirkmc