Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map race in GS transport #208

Merged
merged 1 commit into from
May 18, 2021
Merged

map race in GS transport #208

merged 1 commit into from
May 18, 2021

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 18, 2021

Fixes #206

@codecov-commenter
Copy link

Codecov Report

Merging #208 (c17b47b) into master (e69af10) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   65.05%   65.12%   +0.07%     
==========================================
  Files          24       24              
  Lines        2624     2624              
==========================================
+ Hits         1707     1709       +2     
+ Misses        575      574       -1     
+ Partials      342      341       -1     
Impacted Files Coverage Δ
transport/graphsync/graphsync.go 77.77% <ø> (ø)
channelmonitor/channelmonitor.go 73.27% <0.00%> (-0.93%) ⬇️
network/libp2p_impl.go 72.26% <0.00%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69af10...c17b47b. Read the comment docs.

@dirkmc dirkmc merged commit 717c6d9 into master May 18, 2021
@dirkmc dirkmc deleted the fix/gs-tsport-map-race branch May 18, 2021 11:03
@dirkmc dirkmc mentioned this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphsync data race on cleanup
2 participants