Handle data-sent and data-queued events in the TransferFinished state #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulk
approved these changes
Aug 18, 2021
channels/channels_test.go
Outdated
Comment on lines
165
to
166
|
|
||
|
|
There was a problem hiding this comment.
Apologies, need to setup gofmt on my new Goland installation.
channels/channels_fsm.go
Outdated
Comment on lines
68
to
70
| chst.AddLog("") | ||
| return nil | ||
| }), |
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 67.44% 67.70% +0.26%
==========================================
Files 24 24
Lines 3044 3044
==========================================
+ Hits 2053 2061 +8
+ Misses 636 627 -9
- Partials 355 356 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #234 .
OnDataSenthook for blocks that have already been sent which in turn will fire theDataSentdata-transfer event. The same applies to theDataQueuedevent.DataSentProgressand aDataQueuedProgressevents a while ago in Dont double count data sent #185. These events are only emitted the first time we send a block to a remote peer.TransferFinishedstate, we can still receiveDataSentandDataQueuedevents for blocks that have already been sent. We need to handle these events gracefully in theTransferFinishedstate. We do see a LOT of restarts in Estaury's logs for data-transfer across the board. See attached.DataSentProgressand aDataQueuedProgressevents in theTransferFinishedstate and this is confirmed by Estuary's logs.Note: I don't think this error actually causes storage deals to fail but still nice to fix to clean up the logs.
shuttle-logs-bad-tx3 (1).gz