Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle QUALITY censorship #591

Closed
3 tasks done
Stebalien opened this issue Aug 26, 2024 · 0 comments · Fixed by #606
Closed
3 tasks done

Handle QUALITY censorship #591

Stebalien opened this issue Aug 26, 2024 · 0 comments · Fixed by #606
Assignees
@masih
Milestone
M2: Mainnet Passi...

Comments

@Stebalien
Copy link
Member

Stebalien commented Aug 26, 2024 •
edited by masih
Loading

filecoin-project/FIPs#809 (comment)

Tasks
Preview Give feedback
@Stebalien Stebalien self-assigned this Aug 26, 2024
@Stebalien Stebalien added this to F3 Aug 26, 2024
@github-project-automation github-project-automation bot moved this to Todo in F3 Aug 26, 2024
@Stebalien Stebalien assigned masih and unassigned Stebalien Aug 26, 2024
@masih masih moved this from Todo to In progress in F3 Aug 27, 2024
masih added a commit that referenced this issue Aug 27, 2024
@masih
Include QUALITY messages in rebroadcast
d3cec98 
To improve censorship resistance and avoid lack of progress due to
partially disseminated QUALITY messages include them in rebroadcast.

More specifically, the

Part of #591
@masih masih mentioned this issue Aug 27, 2024
Merged
masih added a commit that referenced this issue Aug 27, 2024
@masih
Include QUALITY messages in rebroadcast
db3bb25 
To improve censorship resistance and avoid lack of progress due to
partially disseminated QUALITY messages include them in rebroadcast.

Part of #591
github-merge-queue bot pushed a commit that referenced this issue Aug 27, 2024
@masih
Include QUALITY messages in rebroadcast (#597)
3cd2e35 
To improve censorship resistance and avoid lack of progress due to
partially disseminated QUALITY messages include them in rebroadcast.

Part of #591
@Kubuxu Kubuxu mentioned this issue Aug 28, 2024
Closed
masih added a commit that referenced this issue Aug 29, 2024
@masih
Handle late arriving QUALITY messages in every round
5d7eb2a 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains prior to executing CONVERGE phase based
    on the initial proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal should there be a strong quorum for it.
The changes here essentially execute the QUALITY phase prior to
`tryConverge`.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809 (comment)

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
@masih masih mentioned this issue Aug 29, 2024
Merged
masih added a commit that referenced this issue Aug 29, 2024
@masih
Handle late arriving QUALITY messages in every round
efb6b96 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains prior to executing CONVERGE phase based
    on the initial proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal should there be a strong quorum for it.
The changes here essentially execute the QUALITY phase prior to
`tryConverge`.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809 (comment)

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Aug 29, 2024
@masih
Handle late arriving QUALITY messages in every round
2692193 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains prior to executing CONVERGE phase based
    on the initial proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal should there be a strong quorum for it.
The changes here essentially execute the QUALITY phase prior to
`tryConverge`.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809 (comment)

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Aug 29, 2024
@masih
Handle late arriving QUALITY messages in every round
c0765ca 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains prior to executing CONVERGE phase based
    on the initial proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. The changes here essentially execute the QUALITY phase
prior to `tryConverge` but without updating the current proposal.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Aug 30, 2024
@masih
Handle late arriving QUALITY messages in every round
874a82d 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains prior to executing CONVERGE phase based
    on the initial proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. The changes here essentially execute the QUALITY phase
prior to `tryConverge` but without updating the current proposal.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Aug 30, 2024
@masih
Handle late arriving QUALITY messages in every round
faf34c2 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains at any round or phase based on the initial
    proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. No that the changes here do not update the current
proposal based on late arriving QUALITY messages.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Aug 30, 2024
@masih
Handle late arriving QUALITY messages in every round
6dd4129 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains at any round or phase based on the initial
    proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. No that the changes here do not update the current
proposal based on late arriving QUALITY messages.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Sep 2, 2024
@masih
Handle late arriving QUALITY messages in every round
bb270fe 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains at any round or phase based on the initial
    proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. No that the changes here do not update the current
proposal based on late arriving QUALITY messages.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
masih added a commit that referenced this issue Sep 3, 2024
@masih
Handle late arriving QUALITY messages in every round
c6009b9 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains at any round or phase based on the initial
    proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. No that the changes here do not update the current
proposal based on late arriving QUALITY messages.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
github-merge-queue bot pushed a commit that referenced this issue Sep 3, 2024
@masih
Handle late arriving QUALITY messages in every round (#606)
33b0a89 
Change the core GPBFT protocol to:
 1) accept QUALITY messages in ant phase or round.
 2) update candidate chains at any round or phase based on the initial
    proposal.

This would permit participants with late-arriving/partially delivered
QUALITY messages to affect the candidates chains in CONVERGE phase to
sway for the initial proposal or any of its prefixes should there be a
strong quorum. No that the changes here do not update the current
proposal based on late arriving QUALITY messages.

The changes above, in conjunction with rebroadcast of QUALITY messages
introduced in #597 should significantly reduce the likelihood of lack of
progress due to partially seen QUALITY messages. See:

 - filecoin-project/FIPs#809
 #discussioncomment-10409902

As part of the changes introduced by this commit, the data structure
used by the instance to store candidate chains is changed to a map of
chain keys for a faster candidate set update (O(1)), and a more
concise way to assure uniqueness of the set of candidates.

Fixes #591
@masih masih closed this as completed in #606 Sep 3, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in F3 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
M2: Mainnet Passive Testing
Development

Successfully merging a pull request may close this issue.

Handle late arriving QUALITY messages in every round filecoin-project/go-f3
2 participants
@masih @Stebalien