Measure time spent on validating messages tagged by result #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 79.79% 79.69% -0.11%
==========================================
Files 44 44
Lines 4084 4103 +19
==========================================
+ Hits 3259 3270 +11
- Misses 494 504 +10
+ Partials 331 329 -2
|
Stebalien
reviewed
Jul 29, 2024
masih
force-pushed
the
masih/validation-time-metric
branch
from
496d416 to
d6b21b9
Compare
Kubuxu
reviewed
Jul 30, 2024
masih
force-pushed
the
masih/validation-time-metric
branch
from
d6b21b9 to
5da1130
Compare
8 tasks
Kubuxu
approved these changes
Jul 30, 2024
Measure the time spent on validating messages and tag the metric by validation result.
masih
force-pushed
the
masih/validation-time-metric
branch
from
5da1130 to
b00f101
Compare
masih
commented
Jul 30, 2024
| validationTime: must(meter.Int64Histogram("f3_validation_time_ms", | ||
| metric.WithDescription("Histogram of time spent validating broadcasted in milliseconds"), | ||
| metric.WithExplicitBucketBoundaries(1.0, 2.0, 3.0, 5.0, 10.0, 20.0, 30.0, 40.0, 50.0, 100.0, 200.0, 300.0, 400.0, 500.0, 1000.0), | ||
| metric.WithUnit("ms"), |
There was a problem hiding this comment.
@Stebalien millisecond unit example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure the time spent on validating messages and tag the metric by validation result.