Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default GOGC for CI fuzz tests #562

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Conversation

masih
Copy link
Member

@masih masih commented Aug 11, 2024

Remove the GOGC override for CI fuzz tests, because:

  • without it fuzz tests run faster,
  • we are close to the runner's memory limit, and we get false positive failures caused bo GitHub Actions SIGTERM if we go over the limit.

Remove the GOGC override for CI fuzz tests, because:
 * without it fuzz tests run faster,
 * we are close to the runner's memory limit, and we get false positive
   failures caused bo GitHub Actions SIGTERM if we go over the limit.
@masih masih requested review from Stebalien and Kubuxu August 11, 2024 09:03
@masih
Copy link
Member Author

masih commented Aug 11, 2024

Compared to main, fuzz tests here run about 1m faster.

@masih masih marked this pull request as ready for review August 11, 2024 09:03
@masih masih enabled auto-merge August 11, 2024 09:04
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.31%. Comparing base (fee0328) to head (f53fd05).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   80.38%   80.31%   -0.07%     
==========================================
  Files          47       47              
  Lines        4328     4328              
==========================================
- Hits         3479     3476       -3     
- Misses        516      517       +1     
- Partials      333      335       +2     

see 6 files with indirect coverage changes

@masih masih added this pull request to the merge queue Aug 11, 2024
Merged via the queue into main with commit eef348e Aug 11, 2024
13 checks passed
@masih masih deleted the masih/rm-fuzz-gogc-override branch August 11, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants